Stable release 3.4.8 available

[Julien BLACHE]

Michael Tautschnig <mt at debian.org> wrote:

Hi,

> exceptions to this rule must also be noted: [bdfc127] introduced a new feature
> in setup-storage, enabling user-defined partition alignment. Yet we believe that

I'd have to review & test the current code (and lack time to do so at
the moment) but I am encountering serious issues with that code and
msdos disklabels (especially extended partitions).

One issue I'm seeing is the end position for the last partition
exceeding the device size when that last partition is an extended
partition.

I'm also still doubtful of backward-compatibility with previous FAI
releases, again, when it comes to msdos disklabels. I attempted to fix
this, but... it wasn't exactly pretty.

Modifications were made since, so if someone can say for sure that:
 - it is compatible with previous releases when preserving msdos
   disklabels;
 - it doesn't break in corner cases like the above;

Then fine. Otherwise, that code must not go anywhere near stable.

As proposed already, let's just forget about alignment and msdos
disklabel. It's not worth the hassle.

It works superbly with GPT, though, no issue there.

I'm swamped right now, I'm afraid won't find the time to dig into this
for weeks if not months, otherwise I'd have raised the issue earlier
with patches :/

JB.

-- 
 Julien BLACHE - Debian & GNU/Linux Developer - <jblache at debian.org> 
 
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169