Bug#868267: fai-client: fetch-basefile breaks for hostnames with hyphens

[andrew bezella]

thanks for following up on this!

i think the stripping of the file extension (line 47 in the old code)
needs to be added back in, otherwise the defined classes would have to
match the basefile+extension:
https://github.com/faiproject/fai/pull/61

i also noticed that one problem with this approach is that it does
limit the basefiles to short hostnames.  but that's not new and seems
like an edge case.

On Thu, 2017-07-27 at 11:45 +0200, Thomas Lange wrote:
> I have patched fetch-basefile so this should now work as
> expected. Instead of an eval and indirect shell variables, I just use
> an array and loop over this. No performce penalty unless you have
> some
> thousands of classes defined for a client and a million of base files
> ;-)
> 
> Here are the diffs:
> https://github.com/faiproject/fai/commit/eedc1c27229aa77f81f8d718214a
> 5b4f4dc2c908
> https://github.com/faiproject/fai/commit/bc88a9e5d2ca21d7c19cb7b39c9e
> a64cf905c2fc
> 
> So, I think currently there's no need to substitute hyphen and dot
> with underscore for the FAI class names and we can leave this
> unchanged. But I will improve the documentation about class names.
-- 
andrew bezella <abezella at archive.org>
internet archive