Bug#868267: fai-client: fetch-basefile breaks for hostnames with hyphens

Thomas Lange lange at informatik.uni-koeln.de
Thu Jul 27 11:45:06 CEST 2017


I have patched fetch-basefile so this should now work as
expected. Instead of an eval and indirect shell variables, I just use
an array and loop over this. No performce penalty unless you have some
thousands of classes defined for a client and a million of base files ;-)

Here are the diffs:
https://github.com/faiproject/fai/commit/eedc1c27229aa77f81f8d718214a5b4f4dc2c908
https://github.com/faiproject/fai/commit/bc88a9e5d2ca21d7c19cb7b39c9ea64cf905c2fc

So, I think currently there's no need to substitute hyphen and dot
with underscore for the FAI class names and we can leave this
unchanged. But I will improve the documentation about class names.
-- 
regards Thomas


More information about the linux-fai mailing list