Bug#868267: fai-client: fetch-basefile breaks for hostnames with hyphens

[andrew bezella]

in general, the hyphen not being allowed in a class name seems a
documented restriction and not a bug.  the fai-class man page states:
> All class names should be written in uppercase letters (execpt the class 
> of the hostname). Do not use a dash, use an underscore.

it could perhaps be re-worded along the lines of "All class names are
restricted to uppercase letters and underscores [A-Z_] (except the FAI-
defined class matching the hostname)" and maybe placed more prominently
in the man page and other documentation (and i just noticed there's a
typo in there: "execpt" -> "except")

i'd tend to agree that formally allowing hyphens in the class name
would take significant effort and likely result in some breakage.

for this bug in particular, there might be something else going on? 
we're trailing by a few versions, but the majority of our dirinstalls
are for hosts with hyphens in their name and we have (although not
recently) also had bare-metal hosts with hyphens.  unless i'm missing
something, i can't reproduce on a host w/a hyphen using the script from
5.3.4:
+ revclasses='LAST vm-ops0.us.archive.org XENIAL64 XENIAL UBUNTU DEBIAN FAIBASE DHCPC CHROOT LINUX DEFAULT '
+ for c in '$revclasses'
+ id=found_LAST
+ '[' X '!=' X ']'
+ for c in '$revclasses'
+ id=found_vm-ops0.us.archive.org
+ '[' X '!=' X ']'
+ for c in '$revclasses'
+ id=found_XENIAL64
+ '[' XXENIAL64.tar.xz '!=' X ']'
+ found=1

hth...

	andy

-- 
andrew bezella <abezella at archive.org>
internet archive