Bug#868267: fai-client: fetch-basefile breaks for hostnames with hyphens

[Andreas Heinlein]

Am 26.07.2017 um 15:51 schrieb Thomas Lange:
>>>>>> On Thu, 13 Jul 2017 17:41:56 -0400, Arcady Genkin <agenkin at gmail.com> said:
>     > guessing that the hyphen in the host name is causing the problem (the hostname
>     > is "eddie-vm.teach.cs.toronto.edu" which defines a FAI class of the same name).
> Hi Arcady,
>
> the problem is, that FAI class names should not contain a hyphen. IIRC
> this was done because cfengine classes also do not allow hyphens, but
> underscore.
>
> One solution would be to substitute the hyphen in the hostname into a
> underscore, which is allowed in FAI classes.
>
> I fear we will break more things if we allow hyphens in class names.
>
> Any comments on this from the mailing list (CC)?
I have a large number of hosts here with hyphens in their hostname, and
they all install with FAI just fine. I am even using the implicit
host-name classes for some hosts, but admittedly not with cfengine. But
there are cfengine scripts with other class names that run just fine on
these hosts.

If there really is a potential problem, converting hyphen to underscore
in implicit classes derived from hostnames is probably the best idea.
Underscores are not allowed in hostnames, so there can be no collision
with another host named 'eddie_vm'. I could live with that.

Andreas