setup-storage -D

[Thomas Neumann]

Hello

setup-storage has 3 ways to obtain a list of suitable disk devices:
1) automatically via executing the shell script 'fai-disk-info'
2) provided by environment variable 'disklist'
3) provided by command line option '-D'

Does anybody use the third option? You are supposed to feed the devices as 
space-separated values.

>From the manpage

 -D disks
   Specify  the  list  of disk drives to be configured using setup-storage.
   Overrides disklist.

>From the help message

setup-storage version 1.5

USAGE: [-X]                     no test, your harddisks will be formated
                                default: only test, no real formating
       [-f<config-filename>]    default: parse classes
       [-d]                     enable debug output (equivalent to debug=1)
       [-s]                     perform syntax check only and exit
       [-D<disks>]              override disklist variable by space-separated 
<disks>
       [-L<logdir>]             use <logdir> instead of LOGDIR variable
       [-h]                     print this help message


Because it's broken. What actually happens is setup-storage picking up the 
first device and ignoring all other devices without any kind of warning.

sample output for multiple devices (not using -D)

  /usr/sbin/setup-storage -d
  setup-storage is running in test-only mode
  disklist: sda
  sdb
  sdc
  sdd

using -D with multiple values to imitate previous output

  /usr/sbin/setup-storage -d -D sda sdb sdc sdd
  setup-storage is running in test-only mode
  disklist: sda

suggested solution: parse given string as comma separated values

  /usr/sbin/setup-storage -d -D sda,sdb,sdc,sdd
  setup-storage is running in test-only mode
  disklist: sda
  sdb
  sdc
  sdd

The patch itself is trivial. I just want to know if anybody is actually using 
this feature.

bye
thomas