Bug in FAIBASE/30-interface?

[Michael Goetze]

Hi Dirk,

On 02/23/2011 03:37 PM, Dirk Geschke wrote:
> I think there is a logical bug in FAIBASE/30-interface. The line
> 
>   if ifclass DHCPC && [ $FAI_ACTION != "softupdate" ]
> 
> skips this part for DHCPC hosts during a softupdate. But then one
> runs in the else-Part and then we end up in
> 
>   [ -s /etc/resolv.conf ] && cp -p /etc/resolv.conf $target/etc
> 
> This is not really useful during a softupdate:

That's correct. I fixed this in FAI trunk a few weeks ago, so the issue
will not be present in FAI 4.0. Here's my patch:

Index: scripts/DEBIAN/30-interface
===================================================================
--- scripts/DEBIAN/30-interface	(revision 6289)
+++ scripts/DEBIAN/30-interface	(revision 6290)
@@ -10,7 +10,8 @@
 	iface lo inet loopback
 	iface eth0 inet dhcp
 EOF
-else
+elif [ $FAI_ACTION != "softupdate" ]
+then
       [ -n "$IPADDR" ] && cat > $target/etc/network/interfaces <<-EOF
 	# generated by FAI
 	auto lo eth0


@Mika: I think this could be safely included in the stable branch.

Regards,
Michael