[RFC] setup-storage: generate scripts for partition table (re)creation

[Julien BLACHE]

Michael Tautschnig <mt at debian.org> wrote:

Hi,

> parted commands. Ok, filesystems require some extra work, but then again I'm not
> sure whether you actually want/need that - at least not in context of failing
> RAID devices. For LVM the pvcreate commands will have to be executed.

I have filesystems alongside partitions used for RAID, so yes I do want
that :)
 
>> So you need at least 2 flags: log command and execute command.
>
> As said above: Should mostly just be the logging, and maybe do it as follows:
>
> - Add a function that does logging
> - Add a flag to push_command that causes the logging function to be called
> - If commands are not pushed because of preserve being in effect, call the
>   logging function directly.

Having push_command take the two flags would help reducing changes to
the preserve codepath a lot, I think.

JB.

-- 
 Julien BLACHE - Debian & GNU/Linux Developer - <jblache at debian.org> 
 
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169