[Fai-commit] r4161 - in people: . h01ger/live-CD h01ger/live-CD/live-include-dir oz oz/fai-conf-update

[Holger Levsen]

Hi Oliver,

let me first of all repeat: I'm happy you committed this and work on this 
stuff. 

So please don't misunderstand my comments and questions :) I don't mind that 
you temporarily break/broke stuff - I just keep an eye on it to get it 
working ;)

Also I wrote this mail to the list, so that others see that there is 
development and to encourage them to participate / choose such an open work 
style themselves :)

On Monday 20 November 2006 20:24, Oliver Osburg wrote:
>    people/oz/fai-conf-update/README.txt
>    people/oz/fai-conf-update/fai-conf-update.sh

> Modified: people/h01ger/live-CD/live-include-dir/real-hook
> ===================================================================
> -cp -avx /usr/share/doc/fai-doc/examples/simple/* /srv/fai/config/
> +cp -ravx /usr/share/doc/fai-doc/examples/simple/* /srv/fai/config/

unneeded changes as -a includes -r :)

>  #
> +# copy base.tgz
> +#
> +cp base.tgz /var/tmp

please add a #fixme comment for this. also you broke the automatic build with 
it, as there is no base.tgz...

>  PACKAGES install
[...]
> libnet-perl console-tools console-common expect iproute udev subversion
> grub hwtools read-edid 
> -debian-archive-keyring 
> +debian-archive-keyring grub live-package

grub was already there, just a line above. and live-package is not needed on 
the fai-cd - it's only needed to build it.

> +swapoff /dev/hda5

better use "swapoff -a" (and/or addd a #fixme to the code here, please)

> +cp -rp /srv/fai/config $target/srv/fai/

I suggest using -a instead :)

> -cat > /srv/fai/config/scripts/GRUB/10-setup << 'EOF'
> +cat /srv/fai/config/scripts/GRUB/10-setup << 'EOF'

Aeh, I'm fairly sure the ">" is needed here. Did you test that?

>  #! /bin/bash
>  set -a
> -[ -r /tmp/fai/disk_var.sh ] && . /tmp/fai/disk_var.sh
> +[ -r /var/log/fai/current/disk_var.sh ] && .
> /var/log/fai/current/disk_var.sh error=0 ; trap "error=$((error|1))" ERR

I fail to understand both lines, yours and mine :)

> -deb file:///media/mirror/debian etch main contrib non-free
> +deb file:///media/mirror/debian etch main

why?

> Added: people/oz/fai-conf-update/README.txt
> Added: people/oz/fai-conf-update/fai-conf-update.sh

Since I'm a bit in mentor mode anyway: splitting commits into related files is 
much easier to understand. For a few moments I thought these two files are 
related to my fai-cd...


regards,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.uni-koeln.de/pipermail/linux-fai-devel/attachments/20061121/ea4c585b/attachment.bin