potential patch to check-cross-arch

Matteo Guglielmi Matteo.Guglielmi at dalco.ch
Thu Oct 10 11:11:38 CEST 2019


Actually I'm not sure if your patch is correct

because despite the fact that it does not cause

a crash.



In fact,


given the fact that on suse systems:


/bin/ls


is a symlink to:


/usr/bin/ls


what happens is that:


$_ls


whose absolute path is:


/srv/fai/nfsroot/target/bin/ls


will now be a symlink to:


/srv/fai/nfsroot/usr/bin/ls


instead of:


/srv/fai/nfsroot/target/usr/bin/ls



... I hope it's clear.




So,




the correct patch should be mine:



info=$(file $(readlink -m $_ls))


because, relative to the nfsroot we have:




_ls=/target/bin/ls



_ls=$(readlink -m $_ls)



echo $_ls



/target/usr/bin/ls






________________________________
From: linux-fai <linux-fai-bounces at uni-koeln.de> on behalf of Matteo Guglielmi <Matteo.Guglielmi at dalco.ch>
Sent: Thursday, October 10, 2019 8:40:33 AM
To: fully automatic installation for Linux
Subject: Re: potential patch to check-cross-arch

openSUSE Leap 15.0/15.1

SLES/SLED 15.0/15.1


yes,


both patches do work:


info=$(file -L $_ls)


info=$(file $(readlink -m $_ls))



your patch is better.

________________________________
From: linux-fai <linux-fai-bounces at uni-koeln.de> on behalf of Thomas Lange <lange at informatik.uni-koeln.de>
Sent: Wednesday, October 9, 2019 6:39:41 PM
To: fully automatic installation for Linux
Subject: Re: potential patch to check-cross-arch

>>>>> On Wed, 9 Oct 2019 15:40:02 +0000, Matteo Guglielmi <Matteo.Guglielmi at dalco.ch> said:

    > This script:
    > /srv/fai/nfsroot/usr/lib/fai/check-cross-arch

    > fails (line 36: info=$(file $_ls)) on openSUSE
    > and Suse Linux Enterprise systems because:
Which openSUSE version are you using?
Does file -L help?

--
regards Thomas


More information about the linux-fai mailing list