Minor bug in subroutines-linux:161 (and fix)

[Geert Stappers]

On Wed, Nov 05, 2003 at 10:21:36PM +0100, W. Borgert wrote:
> Hi,
> 
> first the return value of a remote call to test -s is queried:
> 
>     testcmd="test -s /boot/fai/$HOSTNAME-localboot ; echo \$?"
>     ret=`$FAI_REMOTESH -l $LOGUSER ${SERVER} "$testcmd"`
> 
> If rsh fails (here: permission problems), $ret is empty and
> 
>     if [ "$ret" -ne 0 ]; then
> 
> is invalid.  Please, insert something like this before:
> 
>     if [ -z "$ret" ]; then
>         echo "Big problem.  Call the FAI hotline."
>         ret = 0
>     fi
> 

I do see the point that you are making,
could you provide us with unifed patch ( diff -u script.original script ) ?


> Cheers, WB

GS