pull request for setup-storage
Thomas Neumann
blacky+fai at fluffbunny.de
Sat Aug 2 00:12:26 CEST 2014
Hello Thomas, Kerim and who else is listening
PullRequest https://github.com/faiproject/fai/pull/17
"Please review this patchset to get rid of the global variable %FAI::disk_var
and the implicit usage of %FAI::configs in find_boot_mnt_point().
Patches can be applied one after another, alls patches verify successfully
against the unit test. The final patch requires a modification of the setup-
storage script. (included in the patch) The unit test results were generated
by an unmodified setup-storage 1.6.
(This is one of the steps necessary to turn Fstab.pm into a proper module
with it's own namespace.)"
My branch with the changes is located at
https://github.com/ThomasNeumann/setup-storage/tree/refactor_Fstab.pm
The long term goal would be to get rid of all global variables and decouple
all modules in order to make it more obvious what is going on.
bye
thomas
More information about the linux-fai-devel
mailing list