[PATCH] Allow partition size to be define relative to RAM size

[Julien BLACHE]

Michael Tautschnig <mt at debian.org> wrote:

Hi,

> I'll reply to this one first; one general remark applies to your other patches
> as well: Would you mind adding those patches to the experimental branch

Sure, no problem!

> yourself? I don't know whether you already have commit rights in the FAI
> repository, but I guess Thomas could take care of this pretty much

I don't, AFAIK.

>> When using mixed ranges, be careful wrt the min < max
>> constraint. Currently there is no specific handling for this case, not
>> sure there is a need for it.
>
> If min < max you'll get an "internal error" of setup-storage as the make_range
> function, which will eventually process the values, does check for this. Not
> truly nice, but at least we should not end up with some completely broken
> system.

Yep, I checked and verified that. I'm still pondering whether we could
change that so that:

 RAM:100%-10G  would mean "as big as RAM but no greater than 10G"
and
 10G-RAM:100%  would mean "at least 10G if RAM < 10G, between 10G and
               RAM size otherwise"

I think it could be useful. At that point it's icing on the cake, but I
may toy with that and add it later. I may even need it for my
deployments...

> From my POV the patch looks really good; I'd prefer if you could add it to the
> experimental branch yourself, but if you don't like to I'll take care of that.

Will do, access permitting :)

JB.

-- 
 Julien BLACHE <jblache at debian.org>  |  Debian, because code matters more 
 Debian & GNU/Linux Developer        |       <http://www.debian.org>
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169