config space leftovers, when using own FAI_ACTION

Waldemar Brodkorb fai at waldemar-brodkorb.de
Tue Apr 13 20:59:53 CEST 2010


Hi,

when using some home made FAI actions implemented as hooks, the
config space is not automatically unmounted, when NFS is used.

What about something like the attached patch, to fix this
situations?

bye
 Waldemar
-------------- next part --------------
Index: lib/subroutines
===================================================================
--- lib/subroutines	(revision 5768)
+++ lib/subroutines	(working copy)
@@ -86,6 +86,13 @@
     dmesg > $LOGDIR/dmesg.log
 }
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+umount_cspace() {
+    echo $FAI_CONFIG_SRC | grep -q ^nfs://
+    if [ $? -eq 0 ]; then
+	grep -q " $FAI nfs" /etc/mtab && umount $FAI
+    fi
+}
+# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 jobsrunning() {
 
     # test if jobs are running
@@ -304,6 +311,7 @@
 	    if [ -f $FAI/hooks/$FAI_ACTION ]; then
 		echo "Calling user defined action: $FAI_ACTION"
 		$FAI/hooks/$FAI_ACTION
+		umount_cspace
 	    else
 		echo "ERROR: User defined action $FAI/hooks/$FAI_ACTION not found."
 		sendmon "TASKERROR action 22"
@@ -593,10 +601,7 @@
     task savelog
 
     # umount config space if accessed via nfs
-    echo $FAI_CONFIG_SRC | grep -q ^nfs://
-    if [ $? -eq 0 ]; then
-	grep -q " $FAI nfs" /etc/mtab && umount $FAI
-    fi
+    umount_cspace
 
     if [ -f $stamp ]; then
 	echo "Error while executing commands in subshell."


More information about the linux-fai-devel mailing list