Bug#516385: fai-server: I'd prefer fai-mirror not lie to me about what it's doing.

[Michael Tautschnig]

> Hi,
> 
> On Samstag, 21. Februar 2009, Robin Lee Powell wrote:
> > It's harder to debug things when the program lies to you about what it's
> > doing.  :)  Patch follows.
> >
> >
> > --- /tmp/fai-mirror     2009-02-19 16:31:06.000000000 -0800
> > +++ /usr/bin/fai-mirror 2009-02-20 18:33:50.000000000 -0800
> > @@ -185,7 +185,7 @@
> > -    echo "Adding packages from $NFSROOT/var/tmp/packages.nfsroot"
> > +    echo "Adding packages of $cfdir/NFSROOT."
> 
> > -    echo "Adding packages from base.tgz."
> > +    echo "Adding packages from $NFSROOT/var/tmp/base-pkgs.lis"
> 
> IMHO this patch is suited for 3.2.16-lenny1 and trunk - do you agree? 
> 

No. I don't see the particular improvement, especially the first part of the
patch seems really really strange, because the code in fact uses
$NFSROOT/var/tmp/packages.nfsroot and not $cfdir/NFSROOT. What does the user
know about $NFSROOT/var/tmp/base-pkgs.lis, it's a generated file...

I'm not claiming that the current output is sane, but I think there is some more
work required than such trivial patching.

Thanks,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.uni-koeln.de/pipermail/linux-fai-devel/attachments/20090221/e4b96a00/attachment.bin