patch for #320024

[Michael Tautschnig]

> On Wed, 2005-10-19 at 00:28 +0200, Thomas Lange wrote:
> > Try this one please.
> > 
> > [~]> diff /usr/sbin/fai-cd .
> > 206a207,210
> > > 
> > >     # which components are available? main, contrib non-free
> > >     components=$(find $mirrordir/dists/stable/* -maxdepth 0 -type d -printf "%f\n")
> > > 
> > 214c218
> > < deb file:/media/mirror testing main contrib non-free
> > ---
> > > deb file:/media/mirror stable $components
> 
> Nope. This one also doesn't work in my tests. I had some more testing
> fun yesterday evening and today. I'll explain:
> 
> I found another tricky thing with fai-mirror. 
> When I don't uncomment the apt repository entry for the security updates
> in /etc/fai/sources.list, which is uncommented by default, fai-mirror
> also puts and extra Packages file in
> $mirrordir/dists/stable/updates/main
> 
> That one gets neither catched by my last hardcoded solution nor by your
> new, flexible solution. And because there are some important packages,
> installs wont run. I fell on this today, I did obviously uncomment and
> comment it a bit too randomly the last days when I was tired of too long
> waiting, didn't think it could change something, but today I couldn't
> produce a running cd until I found that.
> 
> I tried hardcoding line 214 to be 
> 
> deb file:/media/mirror stable main updates/main
> 
> and just saw that this works, even if the security repository is not
> included, it creates some errors in the log that the package lists for
> the updates part are missing, but as there are no packages that are
> needed (actually, there are none), it's only an error/warning in the
> log.

Just as an example, I provide my sources.list which I hardcoded into fai-cd:

deb file:/media/mirror sarge main 
deb file:/media/mirror stable main 
deb file:/media/mirror stable/updates main

The first line is required due to my own package repository. And this is exactly
why I filed #329547 - we won't ever know, what strange repositories a user might
have.
> 
> Still, your flexible solution is a better idea, but it would need to be
> extended to handle the things described above correctly. I can try that,
> I need some perl training anyway, but won't come to that today. If
> you're faster, don't hesitate :)
> I will test it here, tomorrow.
> 

Well, the proposed patch is really flexible and probably also very clever - but
as such it is also error-prone. What is so bad about my proposal of a single
variable, where each user can simply set the contents of sources.list - the
defaults might be the current content in fai-cd; of course, we won't want to add
some config file for a sarge-update, but it might as well be set in fai.conf or
make-fai-nfsroot.conf (since an nfsroot is needed by fai-cd anyway).

IMHO this single variable would result in a maybe not that small, but really
simple patch which can easily be verified be the Stable RMs.

Just my 2c,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.uni-koeln.de/pipermail/linux-fai-devel/attachments/20051019/0c519199/attachment.bin