[linux-fai-commit] [faiproject/fai] 6d50cb: Do not use array variable when defining $cmdline, ...

[Thomas Lange]

  Branch: refs/heads/master
  Home:   https://github.com/faiproject/fai
  Commit: 6d50cbee460495ef76c65f350c49e67ac9bbadc9
      https://github.com/faiproject/fai/commit/6d50cbee460495ef76c65f350c49e67ac9bbadc9
  Author: Thomas Lange <lange at informatik.uni-koeln.de>
  Date:   2018-04-25 (Wed, 25 Apr 2018)

  Changed paths:
    M lib/subroutines

  Log Message:
  -----------
  Do not use array variable when defining $cmdline, just a plain string

This change reverts 27c7da57910ecf4e17422948c612c0366bbce0de
and includes some minor changes

When doing UEFI network boot I got this error:

/usr/lib/fai/subroutines: eval: line 794: syntax error near unexpected token `('
/usr/lib/fai/subroutines: eval: line 794: `cmdline=(BOOT_IMAGE=(tftp,192.168.33.250)fai/vmlinuz-4.9.0-5-amd64 ip=dhcp

This is because the cmdline includes a key=value pair where the value
includes (), which breaks the definition of the bash array variable.

e.g.:
BOOT_IMAGE=(tftp,192.168.33.250)fai/vmlinuz-4.9.0-5-amd64 ip=dhcp root=/srv/fai/nfsroot:vers=3 rootovl FAI_FLAGS=verbose,sshd,createvt FAI_CONFIG_SRC=nfs://192.168.33.250/srv/fai/config FAI_ACTION=inventory


  Commit: a2de9fd883554c5fbd1ab7756b455a3bcdae7966
      https://github.com/faiproject/fai/commit/a2de9fd883554c5fbd1ab7756b455a3bcdae7966
  Author: Thomas Lange <lange at informatik.uni-koeln.de>
  Date:   2018-04-25 (Wed, 25 Apr 2018)

  Changed paths:
    M bin/fai-make-nfsroot

  Log Message:
  -----------
  also match --arch ARCH, Closes: #895204


Compare: https://github.com/faiproject/fai/compare/0647e2edbb03...a2de9fd88355