[From nobody Wed Aug 6 14:35:53 2014 From: Thomas Neumann <blacky+fai@fluffbunny.de> To: linux-fai-devel@uni-koeln.de, Kerim =?ISO-8859-1?Q?G=FCney?= <kgueney@uni-koeln.de> Subject: pull request for setup-storage Date: Sat, 02 Aug 2014 00:12:26 +0200 Message-ID: <6548016.vGWWT3kJT0@workbench> User-Agent: KMail/4.12.4 (Linux/3.14-1-amd64; KDE/4.12.4; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hello Thomas, Kerim and who else is listening PullRequest https://github.com/faiproject/fai/pull/17 "Please review this patchset to get rid of the global variable %FAI::disk_var and the implicit usage of %FAI::configs in find_boot_mnt_point(). Patches can be applied one after another, alls patches verify successfully against the unit test. The final patch requires a modification of the setup- storage script. (included in the patch) The unit test results were generated by an unmodified setup-storage 1.6. (This is one of the steps necessary to turn Fstab.pm into a proper module with it's own namespace.)" My branch with the changes is located at https://github.com/ThomasNeumann/setup-storage/tree/refactor_Fstab.pm The long term goal would be to get rid of all global variables and decouple all modules in order to make it more obvious what is going on. bye thomas ]